Add support for Elixir #10

stevedomin · 2017-06-27T07:56:44Z

From @greysteil's PR gocardless/bump-core#57

A starting point for adding Elixir support.

Next step would be to write a parser for the mix.lock file, in Elixir. The JavaScript helper run task and parser are the best places to start for understanding how shelling out to helpers works. We'll probably want to piggy back off of Hex as much as possible here, and include it as a dependency (like we do with Yarn).

Once an Elixir parser is written, the pending specs in spec/bump/file_parsers/elixir/hex_spec.rb should pass. At that point, let's talk about adding the UpdateChecker, FileUpdater and MetadataFinder classes.

greysteil · 2017-07-09T18:03:59Z

helpers/elixir/bin/run.exs

@@ -0,0 +1,65 @@
+defmodule MixfileParser do


I don't know enough Elixir to know if this is possible, but is there any way we could piggy-back off of the parsers within Mix itself, rather than having to roll our own? For example, in Python we can just nick the parse_requirements method from pip.req.req_file (see https://github.com/hmarr/dependabot-core/pull/17/files#diff-894615e139b303f40cb5c0d8ed295021R7)

greysteil · 2017-07-09T18:04:26Z

Looks like a good start! Anything I can do to help?

greysteil · 2017-10-12T08:03:31Z

Update: @stevedomin and I are going to make this happen on Wednesday 18th. 🎉

greysteil · 2017-10-25T21:32:38Z

@stevedomin - what's the best next step on this? Don't want it to lose momentum. Can you push whatever you've got on your machine and add a TODO list of what's remaining?

stevedomin · 2017-11-07T19:04:56Z

@greysteil please before pulling this branch again can you make sure you checkout your local branch to a temp branch, I accidentally removed your commits around metadata.

stevedomin · 2017-11-07T19:08:33Z

Thanks @greysteil! :)

stevedomin · 2018-01-09T12:21:06Z

@greysteil got the UpdateChecker close to finished. Once this is done there is only the FileUpdater left, right?

greysteil · 2018-01-09T12:23:45Z

That's awesome! And yep, that sounds right to me. Want me to take a look through what's here now?

stevedomin · 2018-01-09T12:28:01Z

helpers/elixir/bin/run.exs

+  end
+end
+
+# %Mix.Dep{


This is going to go away before we merge into master

stevedomin · 2018-01-09T12:28:28Z

Yep, go for it!

greysteil · 2018-01-09T12:54:56Z

I'm going to need to do a big rebase on this (makes sense for it to be me as I know the changes in the master best). Can you let me know when everything you've got is pushed up, and I'll get it done?

greysteil · 2018-01-10T18:14:32Z

^^^ It worked!!

OK, remaining TODOs:

A requirements updater (for the update checker)
More specs for the parser (e.g., what does it do when no versions is specified? What does it do for git dependencies)
A FileUpdater

@stevedomin - are you OK to do the FileUpdater? I'll do the requirement updater (it can be in Ruby).

Also, what's happening under the hood in the UpdateChecker? Is Dependabot doing a full install, or just piggy-backing off of mix's resolution logic. Because if it's the former it could be really slow...

stevedomin · 2018-01-11T08:13:25Z

Awesome @greysteil, thank you so much!

Right now, it's doing a full install but I'm working on a version without it. I wanted to get something out of the door, been trying to get it working without the install for way too long.

We can definitely make it work without doing a full install but I'll need to make some changes to the Mix codebase itself though.

Are you ok with getting a working version like this and then once it's out we can figure out to do this without the full install?

I'll do the FileUpdater and add specs to the parser.

greysteil · 2018-01-11T08:42:53Z

Makes sense to me - if you get the FileUpdater done I’m 👍 on shipping

stevedomin · 2018-01-11T09:25:08Z

Awesome!

greysteil · 2018-01-11T16:12:31Z

RequirementsUpdater is done, and pretty solid.

~~One question - for equality, is "== 1.0.0" a valid specifier? And if so, is "= 1.0.0" valid or invalid? We're going to need to handle that if so...~~ It is, and it's fixed. 🎉

greysteil · 2018-01-15T16:39:32Z

@stevedomin - I've added a FileUpdater, and done the mixfile updating logic. Just needs your Elixir code to do the lockfile updating and this will be basically good to do.

greysteil · 2018-01-15T21:42:16Z

@stevedomin - added a couple of failing specs for you. Only thing needed now is the Elixir code to update the lockfile, which I think you can basically pinch from what you wrote for the UpdateChecker...

greysteil · 2018-01-16T20:15:39Z

@stevedomin - I think this is all working, so I'm going to merge and release. Would love your help improving and testing it, though!

stevedomin · 2018-01-17T19:54:31Z

Awesome work and thanks @greysteil. I'll add it to my repos tomorrow.

And I'll check the codebase to see what we can improve. At the very least I'd like to change UpdateChecker so that it doesn't pull the dependencies.

greysteil · 2018-01-17T19:58:01Z

That would be a huge improvement! 🎉

greysteil · 2019-03-13T15:20:23Z

@stevedomin could I get an IP assignment comment from you, just so it's explicit what your intentions were with this PR? Ideally the following text would be amazing:

I'm gifting the IP of the contents of this PR and all previous and future contributions to dependabot-core to Dependabot for it to be used however Dependabot wishes.

Thanks. ❤️

stevedomin · 2019-03-13T19:12:41Z

I'm gifting the IP of the contents of this PR and all previous and future contributions to dependabot-core to Dependabot for it to be used however Dependabot wishes.

greysteil force-pushed the master branch 2 times, most recently from 064a304 to ca403cc Compare July 7, 2017 10:00

greysteil reviewed Jul 9, 2017

View reviewed changes

greysteil mentioned this pull request Jul 29, 2017

Add support for Elixir [WIP] gocardless/bump-core#57

Closed

greysteil force-pushed the master branch from 7836d7e to 2bc70ba Compare September 7, 2017 06:07

greysteil force-pushed the master branch from 82a92e1 to 6ad336e Compare October 2, 2017 20:59

greysteil force-pushed the add-elixir branch from c8ebaa1 to 31797c6 Compare October 4, 2017 13:44

greysteil force-pushed the add-elixir branch from 31797c6 to e3f0a94 Compare October 11, 2017 18:18

stevedomin force-pushed the add-elixir branch from e3f0a94 to 1a402ca Compare October 18, 2017 09:45

stevedomin force-pushed the add-elixir branch from b9fa580 to 7a392a9 Compare November 7, 2017 19:02

greysteil force-pushed the master branch from 706764c to 79615cb Compare November 29, 2017 15:46

greysteil force-pushed the master branch from 3c5741a to 4e5b7aa Compare December 6, 2017 16:58

greysteil force-pushed the master branch 3 times, most recently from 04c822b to 0280cdc Compare December 23, 2017 15:19

stevedomin commented Jan 9, 2018

View reviewed changes

helpers/elixir/bin/run.exs Outdated

end

end

# %Mix.Dep{

Copy link

Contributor Author

stevedomin Jan 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to go away before we merge into master

greysteil force-pushed the add-elixir branch 4 times, most recently from b30f9ff to 843ade3 Compare January 10, 2018 11:48

Add FileFetchers::Elixir::Hex

7677840

greysteil added 3 commits January 11, 2018 11:26

Add first version of requirements updater

4030487

Add Hex::Version class that can handle build infor

5defecc

More comprehensive requirements updater

cc798bb

greysteil force-pushed the add-elixir branch from 5435bb0 to cc798bb Compare January 11, 2018 16:09

greysteil added 3 commits January 15, 2018 16:09

Handle == requirements in Elixir

9121008

First version of FileUpdater

69f7a93

Spec Elixir FileUpdater (mixfile updating only)

b034299

Spec that git source dependencies are removed during parsing

ab2e480

greysteil force-pushed the add-elixir branch from 6accedf to ab2e480 Compare January 15, 2018 20:58

Add (failing) specs for updater

bd1d0a9

greysteil added 2 commits January 16, 2018 19:37

Add working FileUpdater

b58c5c1

Clean up

6292062

greysteil changed the title ~~[WIP] Add support for Elixir~~ Add support for Elixir Jan 16, 2018

greysteil merged commit f2c6852 into master Jan 16, 2018

greysteil deleted the add-elixir branch January 16, 2018 20:15

This was referenced Mar 16, 2018

Bump eslint from 4.18.2 to 4.19.0 in /helpers/yarn #312

Merged

Bump eslint from 4.18.2 to 4.19.0 in /helpers/npm #313

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Elixir #10

Add support for Elixir #10

stevedomin commented Jun 27, 2017

greysteil Jul 9, 2017

greysteil commented Jul 9, 2017

greysteil commented Oct 12, 2017

greysteil commented Oct 25, 2017

stevedomin commented Nov 7, 2017

stevedomin commented Nov 7, 2017

stevedomin commented Jan 9, 2018

greysteil commented Jan 9, 2018

stevedomin Jan 9, 2018

stevedomin commented Jan 9, 2018

greysteil commented Jan 9, 2018 •

edited

Loading

greysteil commented Jan 10, 2018 •

edited

Loading

stevedomin commented Jan 11, 2018

greysteil commented Jan 11, 2018 •

edited

Loading

stevedomin commented Jan 11, 2018

greysteil commented Jan 11, 2018 •

edited

Loading

greysteil commented Jan 15, 2018

greysteil commented Jan 15, 2018

greysteil commented Jan 16, 2018

stevedomin commented Jan 17, 2018

greysteil commented Jan 17, 2018

greysteil commented Mar 13, 2019

stevedomin commented Mar 13, 2019

Add support for Elixir #10

Add support for Elixir #10

Conversation

stevedomin commented Jun 27, 2017

greysteil Jul 9, 2017

Choose a reason for hiding this comment

greysteil commented Jul 9, 2017

greysteil commented Oct 12, 2017

greysteil commented Oct 25, 2017

stevedomin commented Nov 7, 2017

stevedomin commented Nov 7, 2017

stevedomin commented Jan 9, 2018

greysteil commented Jan 9, 2018

stevedomin Jan 9, 2018

Choose a reason for hiding this comment

stevedomin commented Jan 9, 2018

greysteil commented Jan 9, 2018 • edited Loading

greysteil commented Jan 10, 2018 • edited Loading

stevedomin commented Jan 11, 2018

greysteil commented Jan 11, 2018 • edited Loading

stevedomin commented Jan 11, 2018

greysteil commented Jan 11, 2018 • edited Loading

greysteil commented Jan 15, 2018

greysteil commented Jan 15, 2018

greysteil commented Jan 16, 2018

stevedomin commented Jan 17, 2018

greysteil commented Jan 17, 2018

greysteil commented Mar 13, 2019

stevedomin commented Mar 13, 2019

greysteil commented Jan 9, 2018 •

edited

Loading

greysteil commented Jan 10, 2018 •

edited

Loading

greysteil commented Jan 11, 2018 •

edited

Loading

greysteil commented Jan 11, 2018 •

edited

Loading