Bot attempts to update pre-1.0 minor version number #9647
Labels
Comments
github-actions
bot
added
L: git:submodules
jakecoffman
removed
L: go:modules
jszwedko
added a commit
to vectordotdev/vector
that referenced
this issue
Oct 23, 2024
Patch updates, per semvar, have a low risk of incompatibility and so I think they can all be grouped together. I was going to add `minor` here too, but for dependencies pre-1.0, minor updates can be breaking. There is a dependabot issue asking for this behavior to change: dependabot/dependabot-core#9647. Also some discussion about this on: dependabot/dependabot-core#7795 Signed-off-by: Jesse Szwedko <[email protected]>
github-merge-queue bot
pushed a commit
to vectordotdev/vector
that referenced
this issue
Oct 23, 2024
Patch updates, per semvar, have a low risk of incompatibility and so I think they can all be grouped together. I was going to add `minor` here too, but for dependencies pre-1.0, minor updates can be breaking. There is a dependabot issue asking for this behavior to change: dependabot/dependabot-core#9647. Also some discussion about this on: dependabot/dependabot-core#7795 Signed-off-by: Jesse Szwedko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Package ecosystem
Rust crates,
cargopackage managerPackage manager version
No response
Language version
Rust
Manifest location and content before the Dependabot update
No response
dependabot.yml content
No response
Updated dependency
No response
What you expected to see, versus what you actually saw
Dependabot is raising PRs to update the minor version number of Rust crates (example linked below). IIUC semver treats pre-1.0 releases differently from post 1.0 - specifically minor version update is treated as a major release i.e., breaking changes are allowed in a minor version number upgrade. Therefore dependabot should not be attempting, again IIUC, to do minor version upgrades for pre-1.0 releases.
romanz/electrs#1032
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
No response
Smallest manifest that reproduces the issue
No response
The text was updated successfully, but these errors were encountered: