Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone submodules for go_modules file fetcher #4249

Closed
aminjam opened this issue Sep 21, 2021 · 1 comment
Closed

clone submodules for go_modules file fetcher #4249

aminjam opened this issue Sep 21, 2021 · 1 comment
Labels
L: git:submodules Git submodules L: go:modules Golang modules T: feature-request Requests for new features

Comments

@aminjam
Copy link

aminjam commented Sep 21, 2021

We have a go_modules project that utilizes submodules and we use replace directives from the main modules to access other modules. When we run dependabot we see errors that couldn't read go.mod from the submodule.

updater | ERROR <job_206648398> go: code.cloudfoundry.org/[email protected] (replaced by ../garden): reading ../garden/go.mod: open /home/dependabot/dependabot-updater/repo/src/garden/go.mod: no such file or directory

I was able to fix this issue locally and successfully run ./bin/dry-run.rb after changing this line to be the following:

git clone --no-tags --recursive #{br_opt} #{source.url} #{path}

Is it possible to solve this issue in a different way? If not, would it be possible to add a new config so that repositories can clone submodules for go_modules projects?

@aminjam aminjam added the T: feature-request Requests for new features label Sep 21, 2021
geofffranks added a commit to cloudfoundry/routing-release that referenced this issue Oct 19, 2021
geofffranks added a commit to cloudfoundry/routing-release that referenced this issue Oct 25, 2021
@brrygrdn brrygrdn added L: git:submodules Git submodules L: go:modules Golang modules labels Nov 26, 2021
@jakecoffman
Copy link
Member

Submodule cloning was added in #5982 so this should be working now!

Let us know if you're seeing any issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: git:submodules Git submodules L: go:modules Golang modules T: feature-request Requests for new features
Projects
None yet
Development

No branches or pull requests

3 participants