Merge branch 'main' into jakecoffman/push-after-approval

common/lib/dependabot/pull_request_creator/branch_namer.rb

@@ -90,7 +90,9 @@ def dependency_set
       def branch_version_suffix
         dep = dependencies.first
 
-        if library? && ref_changed?(dep) && new_ref(dep)
+        if dep.removed?
+          "-removed"
+        elsif library? && ref_changed?(dep) && new_ref(dep)
           new_ref(dep)
         elsif library?
           sanitized_requirement(dep)

common/spec/dependabot/pull_request_creator/branch_namer_spec.rb

@@ -247,6 +247,43 @@
       end
     end
 
+    context "with a removed transitive dependency" do
+      let(:dependencies) { [removed_dep, parent_dep] }
+      let(:removed_dep) do
+        Dependabot::Dependency.new(
+          name: "business",
+          version: nil,
+          previous_version: "1.4.0",
+          package_manager: "dummy",
+          requirements: [],
+          previous_requirements: [],
+          removed: true
+        )
+      end
+      let(:parent_dep) do
+        Dependabot::Dependency.new(
+          name: "statesman",
+          version: "1.5.0",
+          previous_version: "1.4.0",
+          package_manager: "dummy",
+          requirements: [{
+            file: "Gemfile",
+            requirement: "~> 1.5.0",
+            groups: [],
+            source: nil
+          }],
+          previous_requirements: [{
+            file: "Gemfile",
+            requirement: "~> 1.4.0",
+            groups: [],
+            source: nil
+          }]
+        )
+      end
+
+      it { is_expected.to eq("dependabot/dummy/business-and-statesman--removed") }
+    end
+
     context "with a : in the name" do
       let(:dependency) do
         Dependabot::Dependency.new(