Fix error when Typescript is not installed #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #280. The code was referencing the `typescript` object when it is potentially `null`.
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 29 29
Lines 461 461
=======================================
Hits 452 452
Misses 9 9
Continue to review full report at Codecov.
|
This one is hard. If the environment is complicated and stability is low, it may be not worth. |
mnkhouri
added a commit
that referenced
this pull request
Aug 28, 2018
* master: Upgrade all dependencies (#276) Fix error when Typescript is not installed (#282) Enable ES6/7 syntax in Typescript (#258) Update NPM tokens for deploy from Travis (#278) Recognize object arrays in Webpack module.rules.loaders (#233) Add support for import() expressions (#205) Bump Mocha to 5.x (#274) Fix ignore-bin-package default in ReadMe (#252) Fix typo: pasers -> parsers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #280. The code was referencing the
typescriptobject when itis potentially
null.It's not included in this PR, but we could consider adding a check to
catch this situation in CI (filed as an issue in #281).