Include the names of each special in the README

[rouanw]

to make it easier to find which options to pass to depcheck.

I couldn't find the Grunt special in the codebase - does it still exist?

[rouanw]

The build failure appears unlinked to my changes to the README:

AssertionError: [ 'cross-env' ] deepEqual []
    at /home/travis/build/depcheck/depcheck/build/check-json.js:27:12
    at check (/home/travis/build/depcheck/depcheck/build/check-json.js:25:10)
    at _callee$ (/home/travis/build/depcheck/depcheck/build/check-json.js:46:3)
    at tryCatch (/home/travis/build/depcheck/depcheck/node_modules/regenerator-
# ...
The command "npm run depcheck-json" exited with 1.

Can someone more familiar with the code please take a look? I get the same failure locally on master (node 6.9.1).

[rouanw]

@lijunle will you please take a look? 🔦

[haggholm]

Ditto, blocking #205.

It seems that depcheck is in fact failing to detect all of its own dependencies(!); the test-coverage npm script uses node_modules/.bin/cross-env, but (I suppose) because cross-env is never required by any JS code, it isn’t recognised as a dependency—hence, depcheck fails its own check.

This can be fairly easily worked around by changing

  "scripts": {
    // ...
    "depcheck": "node ./bin/depcheck",
    // ...
  },

to

  "scripts": {
    // ...
    "depcheck": "node ./bin/depcheck --ignores=cross-env",
    // ...
  },

but it feels a bit dirty to have a workaround for depcheck in depcheck itself...

[lijunle]

This looks good! Sorry for my late to review.

[codecov]

Codecov Report

Merging #206 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files          24       24           
  Lines         432      432           
=======================================
  Hits          424      424           
  Misses          8        8

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a675b4...b661a62. Read the comment docs.

[rouanw]

Thanks @lijunle 😄