Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for import() expressions #205

Merged
merged 12 commits into from
Aug 13, 2018
2 changes: 1 addition & 1 deletion src/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default function cli(args, log, error, exit) {
.describe('json', 'Output results to JSON')
.describe('ignores', 'Comma separated package list to ignore')
.describe('ignore-dirs', 'Comma separated folder names to ignore')
.describe('parsers', 'Comma separated glob:pasers pair list')
.describe('parsers', 'Comma separated glob:parser pair list')
.describe('detectors', 'Comma separated detector list')
.describe('specials', 'Comma separated special parser list')
.version('version', 'Show version number', version)
Expand Down
1 change: 1 addition & 0 deletions src/component.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"detector": [
"expressViewEngine",
"gruntLoadTaskCallExpression",
"importCallExpression",
"importDeclaration",
"requireCallExpression",
"requireResolveCallExpression"
Expand Down
1 change: 1 addition & 0 deletions src/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export const defaultOptions = {
availableDetectors.importDeclaration,
availableDetectors.requireCallExpression,
availableDetectors.requireResolveCallExpression,
availableDetectors.importCallExpression,
availableDetectors.gruntLoadTaskCallExpression,
],
specials: lodash.values(availableSpecials),
Expand Down
23 changes: 23 additions & 0 deletions src/detector/importCallExpression.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import lodash from 'lodash';


export default function importCallExpression(node) {
return (
node.type === 'CallExpression' &&
node.callee &&

(
((node.callee.type === 'Identifier' && node.callee.name === 'import') ||
(node.callee.type === 'Import')) ||
(node.callee.type === 'MemberExpression' &&
node.callee.object &&
node.callee.object.name === 'System' &&
node.callee.property &&
node.callee.property.name === 'import')
) &&
node.arguments[0] &&
lodash.isString(node.arguments[0].value)
? [node.arguments[0].value]
: []
);
}
1 change: 1 addition & 0 deletions test/fake_modules/import_function/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import('optimist');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please try the webpack named chunk feature (aka, the magic comment):

import(/* webpackChunkName: 'chunk' */ 'chunk')

5 changes: 5 additions & 0 deletions test/fake_modules/import_function/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"dependencies":{
"optimist": "~0.6.0"
}
}
1 change: 1 addition & 0 deletions test/fake_modules/import_function_missing/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import('anyone');
1 change: 1 addition & 0 deletions test/fake_modules/import_function_missing/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
1 change: 1 addition & 0 deletions test/fake_modules/import_function_webpack/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import(/* webpackChunkName: 'chunk' */ 'optimist');
5 changes: 5 additions & 0 deletions test/fake_modules/import_function_webpack/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"dependencies":{
"optimist": "~0.6.0"
}
}
47 changes: 47 additions & 0 deletions test/spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,53 @@
import depcheck from '../src/index';

export default [
{
name: 'detect missing module for dynamic import() when missing in package.json',
module: 'import_function_missing',
options: {
withoutDev: true,
},
expected: {
dependencies: [],
devDependencies: [],
missing: {
anyone: ['index.js'],
},
using: {
anyone: ['index.js'],
},
},
},
{
name: 'find module for dynamic import() when present',
module: 'import_function',
options: {
withoutDev: true,
},
expected: {
dependencies: [],
devDependencies: [],
missing: {},
using: {
optimist: ['index.js'],
},
},
},
{
name: 'find module for dynamic import() with magic Webpack comment',
module: 'import_function_webpack',
options: {
withoutDev: true,
},
expected: {
dependencies: [],
devDependencies: [],
missing: {},
using: {
optimist: ['index.js'],
},
},
},
{
name: 'missing module for require.resolve when missing in package.json',
module: 'require_resolve_missing',
Expand Down