Publish new release

[vmeurisse]

There are a few fixes that are not yet released in any version 0.6.7...master.
In particular #196 would be very useful.

Could you please release a new version to npm?

[rumpl]

Hey @vmeurisse,

Sure, I'll get to it first thing tomorrow morning, sorry for the inconvenience.

[lijunle]

Hey, Djordje. You could just add a new tag with version name and the release note, then push it to Github. The CI build will publish it to NPM. 2017年6月28日 上午5:29，"Djordje Lukic" <[email protected]>写道： Hey @vmeurisse <https://github.com/vmeurisse>, Sure, I'll get to it first thing tomorrow morning, sorry for the inconvenience. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#213 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPIdIcB2awa0_CgDCEvxy9UOOZdzTnzks5sIXQngaJpZM4OGkkS> .

[niftylettuce]

?

[jwhitmarsh]

@lijunle Any chance this can get published?

[lijunle]

Sorry, James. There are some ESLint failures and test failures. Could you please help to fix them? Then, I can publish a new version. Thanks! Junle

…

On Mon, Oct 9, 2017 at 11:14 PM, James ***@***.***> wrote: @lijunle <https://github.com/lijunle> Any chance this can get published? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#213 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPIdFAWZ8Rv_QNH75TKOV5rmUO7kHtTks5sqjhUgaJpZM4OGkkS> .

[jwhitmarsh]

I've just forked the repo and all the tests are completing.

The lint errors are all no-return-assign errors, so this:

      data => (log = data),
      data => (error = data),

becomes this:

      (data) => {
        log = data;
        return log;
      },
      (data) => {
        error = data;
        return error;
      },

I prefer the first one, but it's not my repo and I don't want to step on toes and change code format, but I'd recommend we just disable the no-return-assignment rule in eslint.

[lijunle]

We don't need to return the value. This is fine:

(data) => { log = data; },

2017年10月10日 16:48，"James" <[email protected]>写道：

…

I've just forked the repo and all the tests are completing. The lint errors are all no-return-assign errors, so this: data => (log = data), data => (error = data), becomes this: (data) => { log = data; return log; }, (data) => { error = data; return error; }, I prefer the first one, but it's not my repo and I don't want to step on toes and change code format, but I'd recommend we just disable the no-return-assignment rule in eslint. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#213 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPIdO8LNOIQfMf9F3a0SXPHY_jLcHbGks5sqy9IgaJpZM4OGkkS> .

[lijunle]

Hi, thank you to @jwhitmarsh . The version 0.6.8 is out. I am closing this issue.