Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions 671 Update Conditions Chapter Summary go back and add it Link Path #34419

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

williamphelps13
Copy link
Contributor

Summary

  • Summarize the changes that have been made to the platform
    • The Conditions Chapter Summary "go back and add it" Link Path was conditional based on the depends of the /orientation page, the /rated-disabilities page, and the /new-disabilities/add page. Which in turn were dependent on the values entered in the claims type page.
    • This allowed users to jump passed the /claim-type page and go to those pages depending on what they checked on the /claim-type page:
      • It would go straight to the /rated-disabilities page if they had checked just "One or more of my rated service-connected conditions has gotten worse" on the /claim-type page
      • it would go to the /new-disabilities/add page if they had checked "A new condition that’s connected to my service"
      • it would go to the /orientation page if they had checked both of these
  • However if they the link in the sentence "This is a list of the conditions you’re claiming in this application. If a condition is missing, please go back and add it." they should really go to the /claims-type no matter what so that if that they can change that value which is what can drastically change that list content below the link.
  • It is a poor user experience in actuality to skip past the /claim-type page
  • It also significantly increased the complexity of the code which resulted in a bug when the addDisabilities page was duplicated.
  • If bug, how to reproduce
    • Select just "A new condition that’s connected to my service"
    • Click the add Conditions Chapter Summary "go back and add it" Link
    • Notice that you are on the orientation page even though that page should not exist with just "A new condition that’s connected to my service" selected
    • Click Continue and you will be directed back to the Introduction page
  • What is the solution, why is this the solution
    • Simplifies the Link to ALWAYS direct to the /claim-type path so that users can add both new AND rated disabilities to that list below the link
  • Which team do you work for, does your team own the maintenance of this component? Conditions Team and Yes

Related issue(s)

Screenrecordings

BUG

new-conditions-page-rollout-bug.mov

FIX

new-conditions-page-rollout-bug-fix.mov

@williamphelps13 williamphelps13 changed the base branch from main to revert-34397-revert-34038-conditions-671-update-feature-toggle-handling-to-allow-platform-array-field-progressive-rollout January 31, 2025 01:37
Base automatically changed from revert-34397-revert-34038-conditions-671-update-feature-toggle-handling-to-allow-platform-array-field-progressive-rollout to main January 31, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants