Fix tests failing due to rendering issues #34183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
it-harrison
commented
Jan 22, 2025
| @@ -131,31 +131,6 @@ describe('focusElement', () => { | |||
| expect(input.getAttribute('tabindex')).to.be.null; | |||
| }); | |||
| }); | |||
| it('should focus on input element', async () => { | |||
| const screen = render( | |||
There was a problem hiding this comment.
duplicate test (see above) so deleting
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
* fix: tests for platform * fix: tests for platform
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
va-vfs-bot
temporarily deployed
to
master/node-upg-rendering-fixes/main
* fix: tests for platform * fix: tests for platform * fix: personId test
randimays
approved these changes
Feb 4, 2025
adamwhitlock1
approved these changes
Feb 4, 2025
asg5704
approved these changes
Feb 4, 2025
Andrew565
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates tests in
/platformthat fail after upgrading to Node 22.An initial list of tests with issues can be found here: https://vfs.atlassian.net/wiki/spaces/DST/pages/3693936781/Failing+platform+tests+under+Node+22#Rendering-Issues