DR | Set DataDog log telemetrySampleRate to 100 #28207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mottie
added
front end
HLR
data-doge
approved these changes
Feb 27, 2024
DLarson-Oddball
pushed a commit
that referenced
this pull request
Feb 28, 2024
pjhill
pushed a commit
that referenced
this pull request
Mar 14, 2024
Midge-dev
added a commit
that referenced
this pull request
Apr 2, 2024
* merged previous work into v2 app * Burials * Merge fixes / redirect / flipper / Intro page functional React * attempt to fix infinite loop * conditional required field changes / relies on pattern changes * add return statements for specs * fixed duplicates / fixed number validation for plotAllowancePartOne * schema changes * Set DataDog log telemetrySampleRate to 100 (#28207) * [21-0966] Implement prefill and read-only veteran information page (#28193) * Implement prefill for form 21-0966 * Implement hasVeteranPrefill function to check for valid prefill data for the veteran flow * Update pages to use strong tags * Implement read only veteran summary page based on prefill data * Implement prefill for form 21-0966 * Implement hasVeteranPrefill function to check for valid prefill data for the veteran flow * Update pages to use strong tags * Implement read only veteran summary page based on prefill data * Update initialize helper function to retain prefill data * Added page not found for unknown URLs in medical records (#28148) * 76825 poa requests table (#28190) * Create POST for declining POA request * Create POST for accepting POA request * Refactor to combine accept and decline using action prop * Create POA Requests Table * Integrate table into POARequests page with a shared mockPOARequests * Fix 'View all' link on widget to allow navigation to table * Add unit tests to fully test table content * Add e2e check for table existing * Fix View all Link jest test * Refactor fetches to two methods to give the caller a more constrained interface * Refactor status check in functional way to enhance readability and maintainability * Move isActionable outside of react component * Schema changes (#28189) * init * schema changes * Update list loop aria labels (#28161) * 526: Implement more accurate "We're missing some information" messages (#25428) * Implement 526 missing identifiers warning component Creates a basic component and unit tests to tell the user they are missing certain identifiers we require before starting the Form 526 flow, and dynamically renders which identifiers are missing so they can share that information with a contact center This is intended to replace all of the the inconsistent and inaccurate message components in src/applications/disability-benefits/all-claims/containers/MissingServices.jsx * Refactor Missing526Identifiers containerm tests Cleans up the formatting and rendering code for Missing526Identifiers to make it more logically organized. Addresses problems with tests that seemed to be working before; ended up having to use a regexp match on the container content for my message paragraph; using typical React Testing Library functions such as getByText is problematic and causes confusing failures because it doesn't support web components, which va-alert is (it's part of the VA component library) * Add Google Analytics logging to message display Adds a recordEvent call to log the appearance of the error message and dynamically includes which data was missing. May consider a better way to include the list of missing identifiers in the analytics log so it is easier to query on in the future. Fix typo on participantId key in test and prop types * Refactor Form526 to render new error messages Replaces the existng Missing Services component renders in Form526EZApp.jsx with the new Missing526Identifiers component. This was done to standardize the messsaging during these situations and to provide the user with exactly which data is missing to share with the contact center. Adds default claims arg to the test page in Form526EZApp.unit.spec.jsx. These styles of tests are now deprecated in our system, but I kept my new tests in the same style for consistency. * Refactor list formatting for older browser compatibility Adds a new utility function to our claims utilities for formatting a list as a human readable string with the correct commas and use of 'and'. Replaces my initial implementation of this in the Missing526Identifiers endpoint which used the Intl.ListFormat function: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/ListFormat As this is a relatively new feature of JavaScript not supported by older browsers (I was told Safari 9 for example, which many veterans are still on, frequently raises errors when we use these features), it's better to use the more vanilla, classic JavaScript approach * Feature gate new and old messaging behavior Adds back the existing messages behavior I had removed in an earlier commit and wraps the new and old behavior in a feature flag. * Add empty string safeguard to title formatter The default argument to this titleLowerCase function is an empty string, however the destructuring below it will leave the firstChar undefined and would error if we tried to lower case it * Refactor Alert to use React children pattern * Improve language in Missing526Identifiers spec * Remove feature flag toggles Removes the front end feature flags I initially implemented here alongside the back end changes in department-of-veterans-affairs/vets-api#14858. I decided it would simplify the code and release rollout to simply check if the new missing identifiers metadata was present (meaning the back end feature toggle was on), and make the component rendering dependent on that instead of checking a flag that is unecessary in this case. * Revert accidental removal of important docstring from existing code * Add slot attr to h2 in VA alert * Use existing utility for formatting lists I wasn't aware of this readable list utility when I made my own, so deleting my implementation and relying on this existing helper. * Fix docstring typo * PR Feedback: Add v3 uswds styling tag to alert message Adds the uswds tag to the alert poriton of the new More Info Needed error message for styling consistency * Mhv 52717 implement visibility restrictions to see mr automated test (#27579) * MHV-52717 Implement visibility restrictions to see MR automated test * MHV-52717 Implement visibility restrictions to see MR automated test * Implement visibility restrictions to see MR automated test. * Add TXT Download for consolidated report (all domains/Blue Button) Update feature toggles * Implement visibility restrictions to see MR automated test. --------- Co-authored-by: Aaron Read <[email protected]> * Mhv 54452 thread with 6 more messages (#28200) * add: verify accordions focus * add: thread-accordions focus verification * add: comment assertion * upd: add wait to test * upd: thread-response.json * add: if else statement * upd: thread-accordion.cypress.spec.js * upd: fix failed test * upd: fix loadSingleThread method * upd: fix failed test --------- Co-authored-by: Aaron Read <[email protected]> * Add profile loading guards * new form version * required field changes * Intro page InProgress component * redirect specs, remove allowance specs * unit tests for chapters 1-5 * labels and page arrangment change * added version to payload * reference V2 * fixes known accessibility issues * remove v1 specs * Add v2 constant * review page tweaks and accessibility * maximal-test.json * remove burial date warning * review page finalization * more CAIA feedback changes * statement of truth change * added feature flag back after cleanup on main * Confirmation page / cleanup * overflow json data * additonal evidence section * typo fix * test data changes * cypress specs * button up / documentation update started * confirmation page finalization * clean up * documentation continued * more docs * spec cleanup * removed moment from submit * temporarily remove v1 schema test * fix failing specs * use version 0 * remove schema test not applicable because not all components used in the form originate from vets-json-schema * classnames * pre-review items: cypress axe added, fdc page added, fdc prop added * additional unit tests * remove unused logic * Intro page link changes * test coverage updates * Team QA fixes: round 1 * Team QA fixes: round 2 * Update README.md * added sme feedback fields to locationOfDeath * Team QA fixes: round 2 (cont.) * adds phoneSchema and emailSchema * added missing email label * Team QA fixes: round 3 * Team QA fixes: round 3 cont. * disable conditional requirement * fixed custom validation for burial date * fix specs * min, max, ovr .json updates * removes broken test --------- Co-authored-by: Dakota Larson <[email protected]> Co-authored-by: Rob Garrison <[email protected]> Co-authored-by: Nick Sprinkle <[email protected]> Co-authored-by: Carlos Felix <[email protected]> Co-authored-by: William Phelps <[email protected]> Co-authored-by: Todd Rizzolo <[email protected]> Co-authored-by: Nathan Burgess <[email protected]> Co-authored-by: Anal Gomes <[email protected]> Co-authored-by: Aaron Read <[email protected]> Co-authored-by: fazilqa <[email protected]> Co-authored-by: Dakota Larson <[email protected]> Co-authored-by: Evan Smith <[email protected]> Co-authored-by: Thomas Blackwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
#76108
Testing done
Screenshots
N/A
What areas of the site does it impact?
All Decision Review apps: HLR, NOD & Supplemental Claims
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websitesSlack channel for questionsRequested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?