EVSS: Add other documents to events timeline (#444)

* EVSS: Add other documents to events timeline

Refs https://github.com/department-of-veterans-affairs/sunsets-team/issues/197

* Add date to objects

* Clearer spec

app/serializers/disability_claim_detail_serializer.rb

@@ -30,6 +30,9 @@ def events_timeline
     # Add tracked items
     events += create_events_for_tracked_items
 
+    # Add documents not associated with a tracked item
+    events += create_events_for_documents
+
     # Make reverse chron with nil date items at the end
     events.compact.sort_by { |h| h[:date] || Date.new }.reverse
   end
@@ -66,6 +69,15 @@ def create_events_for_tracked_items
     end.flatten
   end
 
+  def create_events_for_documents
+    # Objects with trackedItemId are part of other events, so don't duplicate them
+    docs = sub_objects_of('vbaDocumentList').select { |obj| obj['trackedItemId'].nil? }
+    docs = create_documents docs
+    docs.map do |obj|
+      obj.merge(type: :other_documents_list, date: obj[:upload_date])
+    end
+  end
+
   # Order of EVENT_DATE_FIELDS determines which date trumps in timeline sorting
   EVENT_DATE_FIELDS = %i(
     closed_date