Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PHP 8.1 deprecation messages #62

Merged
merged 1 commit into from
May 23, 2022
Merged

Conversation

Doc0x1
Copy link
Contributor

@Doc0x1 Doc0x1 commented May 23, 2022

Specified return type of mixed on ImmutableArray::offsetGet() function to silence PHP deprecation message. Added __serialize() and __unserialize() functions to SerializableContainer class to silence PHP Serializable interface deprecation messages.

The deprecation messages:

PHP Deprecated:  
Denpa\Bitcoin\Responses\BitcoindResponse implements the Serializable interface, which is deprecated.
Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) 
in /var/www/html/vendor/denpa/php-bitcoinrpc/src/Responses/BitcoindResponse.php on line 11
PHP Deprecated:  
Denpa\Bitcoin\Responses\LaravelResponse implements the Serializable interface, which is deprecated.
Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) 
in /var/www/html/vendor/denpa/laravel-bitcoinrpc/src/Responses/LaravelResponse.php on line 9

PHP Deprecated:  
Return type of Denpa\Bitcoin\Config::offsetGet($offset) should either be compatible with 
ArrayAccess::offsetGet(mixed $offset): mixed, or the 
#[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice 
in /var/www/html/vendor/denpa/php-bitcoinrpc/src/Traits/ImmutableArray.php on line 55
PHP Deprecated:  
Return type of Denpa\Bitcoin\Responses\BitcoindResponse::offsetGet($offset) 
should either be compatible with
ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be 
used to temporarily suppress the notice in 
/var/www/html/vendor/denpa/php-bitcoinrpc/src/Traits/ImmutableArray.php on line 55

…n to silence PHP deprecation message. Added __serialize() and __unserialize() functions to SerializableContainer class to silence PHP Serializable interface deprecation messages.
@denpamusic
Copy link
Owner

Thank you for your contribution!

@denpamusic denpamusic merged commit fec246c into denpamusic:2.1.x May 23, 2022
@Doc0x1
Copy link
Contributor Author

Doc0x1 commented May 26, 2022

Thank you for your contribution!

Of course! Thank you for this great package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants