Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not detect any devices after upgrade to v0.4.1 [Ecomax 850i] #56

Closed
4 of 10 tasks
zASSAz opened this issue Dec 17, 2023 · 2 comments
Closed
4 of 10 tasks

Does not detect any devices after upgrade to v0.4.1 [Ecomax 850i] #56

zASSAz opened this issue Dec 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@zASSAz
Copy link

zASSAz commented Dec 17, 2023

Is there an existing issue for this?

  • I have searched the existing issues

I'm having the following issue:

изображение

I have following devices connected:

  • ecoMAX 3xx series
  • ecoMAX 8xx series
  • ecoMAX 9xx series
  • Expansion module B
  • Expansion module C
  • ecoSTER 200/ecoSTER Touch
  • ecoLAMBDA
  • ecoNET 300

I'm connecting to my devices using:

Ethernet/WiFi to RS-485 converter

I'm seeing following log messages:

2023-12-17 12:35:33.284 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/pyplumio/helpers/event_manager.py", line 130, in dispatch
    return_value = await callback(value)
                   ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyplumio/devices/ecomax.py", line 213, in _handle_ecomax_parameters
    parameter.values = values
    ^^^^^^^^^^^^^^^^
AttributeError: 'bool' object has no attribute 'values'

My diagnostics data:

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@zASSAz zASSAz added the bug Something isn't working label Dec 17, 2023
@denpamusic
Copy link
Owner

denpamusic commented Dec 17, 2023 •
edited
Loading

Hi,

Thank you for the feedback!

It seems like there is name collision between circulation_pump sensor here and circulation_pump parameter here. This will affect any device, which advertises circulation pump control.

I've pulled down v0.4.1 release for now, as this is pretty easy to fix. I'll put it back up later today.

Sorry for the inconvenience!

denpamusic added a commit to denpamusic/PyPlumIO that referenced this issue Dec 17, 2023
@denpamusic
Fix naming collision.
de7ee70 
- Rename "circulation_pump" parameter to "circulation_contol".
- Fix incorrect parameter type for "main_heat_source_off_temp" parameter.

Related to: denpamusic/homeassistant-plum-ecomax#56
@denpamusic
Copy link
Owner

This has now been fixed and test case has been added to prevent it from happening in the future.
Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zASSAz @denpamusic