feat: allow --inspect-wait when debugging test #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nayeemrmn
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
LGTM
The breakpoint continues to be triggered only on the first time and not from the second. I'm not sure about underlying cause.
That's not happening for me, but I am seeing after the first run that VSCode defaults to having the debug console open but after future runs it defaults to the terminal where you can see the test results. Maybe that's what you're seeing? Either way tests are being run from the first time, so looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
vscode_deno offers a code lens action "Run Test | Debug". However when clicking the "Debug", it triggers a breakpoint which an user did not set.
Changes made
--inspect-brkor--inspect-wait) based on the behavior of pull request feat: make--inspect-waitdefault when debugging #775.Testing
Tested on windows, not sure about other OS but I think there should be no problem.
Notes for Reviewers
The breakpoint continues to be triggered only on the first time and not from the second. I'm not sure about underlying cause.