Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle nested config files in tasks sidebar #1111

Merged
merged 2 commits into from
May 9, 2024
Merged

fix: handle nested config files in tasks sidebar #1111

merged 2 commits into from
May 9, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Use the correct workspace folder and -c subdir/deno.json when executing subdirectory deno.json tasks via the sidebar. Also dedup some code.

dsherret
dsherret approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/src/tasks_sidebar.ts Show resolved Hide resolved
@nayeemrmn nayeemrmn merged commit d20d478 into denoland:main May 9, 2024
2 checks passed
@nayeemrmn nayeemrmn deleted the tasks-sidebar-subdir-deno-json-fix branch May 9, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nayeemrmn @dsherret