Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(io/bufio): fix handling of trailing new line #990

Merged
merged 2 commits into from
Jul 1, 2021
Merged

fix(io/bufio): fix handling of trailing new line #990

merged 2 commits into from
Jul 1, 2021

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 30, 2021

This PR changes the implementation of readLines to fix #986. It currently uses readStringDelim internally. This PR changes it to use bufReader.readLine, which already implements the correct handling of trailing new line.

closes #986

wperron
wperron approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@wperron wperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 01af5fa into denoland:main Jul 1, 2021
@kt3k kt3k deleted the fix/read-lines branch July 1, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wperron wperron wperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

readLines always yield empty "" at EOF?
2 participants
@kt3k @wperron