Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING std/uuid: rework v4 and v5 module #971

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

lucacasonato
Copy link
Member

This commit updates README, adds better JSDoc, and updates
implementations to use new crypto features.

This commit updates README, adds better JSDoc, and updates
implementations to use new `crypto` features.
Copy link
Contributor

@wperron wperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just some minor changes

uuid/v5.ts Outdated Show resolved Hide resolved
uuid/v4.ts Outdated Show resolved Hide resolved
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 0192a85 into denoland:main Jul 9, 2021
@lucacasonato lucacasonato deleted the rework_uuid branch July 9, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants