feat(node): Add console module #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just exports the `console` object. I tried enabling the Node console tests, but all of them either don't work or don't really apply. Note that Deno's console doesn't have all the same methods as Node's, so this isn't a perfect polyfill. Node has these extra properties: - `Console` - `context` - `profile` - `profileEnd` - `timeStamp` I've marked it as partly implemented for now, although I don't know whether those APIs are worth polyfilling.
kt3k
approved these changes
May 1, 2021
There was a problem hiding this comment.
@Liamolucko LGTM. Thanks!
I didn't know this is a module in node.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just exports the
consoleobject.I tried enabling the Node console tests, but all of them either don't work or don't really apply.
Note that Deno's console doesn't have all the same methods as Node's, so this isn't a perfect polyfill. Node has these extra properties:
ConsolecontextprofileprofileEndtimeStampI've marked it as partly implemented for now, although I don't know whether those APIs are worth polyfilling.