feat(io): add readRange, readRangeSync #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabr
reviewed
May 13, 2021
| const nread = await r.read(p); | ||
| assert(nread !== null, "Unexpected EOF reach while reading a range."); | ||
| assert(nread > 0, "Unexpected read of 0 bytes while reading a range."); | ||
| copy(p, result, off); |
There was a problem hiding this comment.
Why create and copy a new buffer here rather than just read into the result buffer directly?
const nread = await r.read(result.subarray(off))
assert(…)
assert(…)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found I needed to read a range of a seekable file and felt that
readRangeandreadRangeSyncare good compliments toreadAllandrealAllSync, so I wanted to contribute them back tostd.This PR also cleans up the
Buffer()init types to accept what is truly needed to init the buffer which eliminates the need for arbitrary type asserts.