Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Collect coverage from native node tests #879

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Apr 25, 2021

Currently, it looks like the coverage is not being collected from native node tests (https://github.com/denoland/deno_std/runs/2426282821) This PR fixes this problem.

Cause

In the following code, cwd is set to node/_tools directory:

https://github.com/denoland/deno_std/blob/3931030e7fae16158e3b6cb041a2a161c0cba6e3/node/_tools/test.ts#L21-L35

This will cause Deno to create coverage profile in the node/_tools directory instead of the project root directory.

@lucacasonato
Copy link
Member

This being required sounds like an upstream Deno bug. cc @caspervonb

@caspervonb
Copy link
Contributor

Yeah upstream issue, the CLI should be canonicalizing the coverage directory before storing it in env.

@uki00a uki00a deleted the collect-coverage-of-code-covered-by-native-node-tests branch May 19, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants