Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(mime/multipart): return array for multiple values with same form name #722

Merged
merged 9 commits into from
Jul 6, 2021
Merged

BREAKING(mime/multipart): return array for multiple values with same form name #722

merged 9 commits into from
Jul 6, 2021

Conversation

jd1378
Copy link
Contributor

@jd1378 jd1378 commented Feb 11, 2021

also adds the related tests

closes #716

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jd1378
fix(lint): changed single quotes to doubles
c73d16c
@jd1378
refactor(multipart)!: unify data types to array
b2e8d39 
BREAKING CHANGE: renamed keys of `MultipartFormData` interface
file -> files
value -> values

updated tests accordingly
@jd1378
fix(lint): use const for file var in tests
8298ab9
@jd1378 jd1378 changed the title fix(mime/multipart): return array for multiple values with same form name refactor(mime/multipart)!: return array for multiple values with same form name Feb 11, 2021
kt3k
kt3k approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caspervonb
caspervonb approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Friendly remember to re-tag this as BREAKING(mime/multipart) when landing 🙃

@kt3k kt3k changed the title refactor(mime/multipart)!: return array for multiple values with same form name BREAKING(mime/multipart)!: return array for multiple values with same form name Feb 20, 2021
@bartlomieju bartlomieju changed the title BREAKING(mime/multipart)!: return array for multiple values with same form name BREAKING(mime/multipart): return array for multiple values with same form name Jul 6, 2021
@bartlomieju bartlomieju merged commit 416ef01 into denoland:main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@caspervonb caspervonb caspervonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultipartReader.readForm().entries() does not contain all values for same name
5 participants
@jd1378 @CLAassistant @caspervonb @kt3k @bartlomieju