Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: net.Socket #694

Closed
wants to merge 10 commits into from
Closed

[WIP] feat: net.Socket #694

wants to merge 10 commits into from

Conversation

ebebbington
Copy link

@ebebbington ebebbington commented Feb 2, 2021

Partially addresses #666

Moved from https://github.com/denoland/deno, see here for original PR

  • Tests
  • All code required copied over
  • Port bindings
  • Port requires
  • Port primordials
  • Port JS to TS (largely relies on bindings)

@CLAassistant
Copy link

CLAassistant commented Feb 2, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Edward Bebbington seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ebebbington ebebbington changed the title feat: net.Socket [WIP] feat: net.Socket Feb 2, 2021
@ebebbington ebebbington marked this pull request as draft February 2, 2021 16:43
@ebebbington
Copy link
Author

Regarding the latest comments in the original PR, myself and @bartlomieju discussed a few bits on discord:

image
image
image
image

@ebebbington
Copy link
Author

@bartlomieju How would i go about "emulating" some of the internal bindings? Is it just a matter of finding the source code and converting it from c++ into typescript?

@bartlomieju
Copy link
Member

@bartlomieju How would i go about "emulating" some of the internal bindings? Is it just a matter of finding the source code and converting it from c++ into typescript?

@ebebbington yes, pretty much

@ebebbington
Copy link
Author

I believe there's only 1 require statement i need to address, and the rest is porting bindings and adding types

@ebebbington
Copy link
Author

Stopping work on this PR for the time being, until either bindings are implemented (im unable to do them unfortunately) or when #695 is merged (then ill get the tests sorted)

@jopemachine
Copy link
Contributor

jopemachine commented Feb 22, 2021

@bartlomieju How would i go about "emulating" some of the internal bindings? Is it just a matter of finding the source code and converting it from c++ into typescript?

@ebebbington yes, pretty much

As far as I know, Deno uses tokio instead of libuv to handle Async I/O.

Is it possible to emulate these internal bindings (c++ code like tcp_wrap.cc) without libuv?

Should it be implemented through tokio?

@ry
Copy link
Member

ry commented Aug 16, 2021

@ebebbington Thanks for the work on this patch - I'm going to close it tho because it's stale and not close to being mergeable. We very much would like to support std/node/net so hopefully we can come back and reference this patch when someone attempts to undertake it.

@ry ry closed this Aug 16, 2021
@ebebbington
Copy link
Author

@ebebbington Thanks for the work on this patch - I'm going to close it tho because it's stale and not close to being mergeable. We very much would like to support std/node/net so hopefully we can come back and reference this patch when someone attempts to undertake it.

Fair enough :) unfortunately I probably won’t have enough time in the future to carry on with it so best of luck to whoever may wish to take it on in the future!

@cmorten cmorten mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants