-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: net.Socket #694
Conversation
Edward Bebbington seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Regarding the latest comments in the original PR, myself and @bartlomieju discussed a few bits on discord: |
@bartlomieju How would i go about "emulating" some of the internal bindings? Is it just a matter of finding the source code and converting it from c++ into typescript? |
@ebebbington yes, pretty much |
I believe there's only 1 |
Stopping work on this PR for the time being, until either bindings are implemented (im unable to do them unfortunately) or when #695 is merged (then ill get the tests sorted) |
As far as I know, Deno uses tokio instead of libuv to handle Async I/O. Is it possible to emulate these internal bindings (c++ code like Should it be implemented through tokio? |
@ebebbington Thanks for the work on this patch - I'm going to close it tho because it's stale and not close to being mergeable. We very much would like to support std/node/net so hopefully we can come back and reference this patch when someone attempts to undertake it. |
Fair enough :) unfortunately I probably won’t have enough time in the future to carry on with it so best of luck to whoever may wish to take it on in the future! |
Partially addresses #666
Moved from
https://github.com/denoland/deno
, see here for original PR