chore(crypto): switch Wasm crate's sha-1 dependency to sha1 to reflect rename by maintainer #4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SHA-1 implementation from @RustCrypto used by our Wasm bundle used to be published as
sha-1, but is now published assha1(see https://crates.io/crates/sha_1 or RustCrypto/hashes#438 for confirmation). This dependency was changed in denoland/deno at denoland/deno#16327, but the change was never made in this repository. The old package is no longer receiving updates, so we're now a few patches behind.I doubt this is consequential in practice, but we might as well switch to the correct crate, so this PR does so and updates to the latest version. There are no observable changes in performance or size.