Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] delete conn parameter in readRequest #430

Merged
merged 3 commits into from
May 22, 2019
Merged

[http] delete conn parameter in readRequest #430

merged 3 commits into from
May 22, 2019

Conversation

zekth
Copy link
Contributor

@zekth zekth commented May 22, 2019

fix: #427

Also deleted conn property of ServerRequest because it's not used anymore and it's not in the request struct of golang:
https://github.com/golang/go/blob/1d1ba85d9986bb56226046c06dec4ce63ef9fe48/src/net/http/request.go#L107

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@ry ry merged commit 209183e into denoland:master May 22, 2019
@zekth zekth deleted the fix_427 branch May 22, 2019 13:47
@MarkTiedemann MarkTiedemann mentioned this pull request May 23, 2019
ry added a commit to ry/deno_std that referenced this pull request May 23, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
Easier to maintain than manually copy-pasted SVGs from various sources.

---------

Co-authored-by: Asher Gomez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readRequest in go does not take a Conn as an argument
2 participants