feat(node): Duplex.fromWeb
#2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Apr 6, 2022
Co-authored-by: Yoshiya Hinosawa <[email protected]>
|
It looks like they are testing the internal utils (such as Is it possible to somehow borrow these test cases to |
|
@kt3k no idea. looking through those tests, they use an internal symbol for web streams called |
|
Then maybe let's invent something very simple for now. It also will be tested in the implementation of #2061 |
bartlomieju
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #2061
not sure where to put
isReadableStream&isWritableStream.Also it seems node has no test for this