Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node/child_process): support signal parameter for ChildProcess.kill #2083

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Apr 5, 2022

Closes #2080

@uki00a uki00a requested review from bartlomieju and kt3k as code owners April 5, 2022 22:14
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uki00a LGTM. Thanks!

@kt3k kt3k merged commit 71542a6 into denoland:main Apr 6, 2022
@uki00a uki00a deleted the issue-2080 branch April 6, 2022 04:40
crowlKats pushed a commit to crowlKats/deno_std that referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node/child_process: implement ChildProcess.kill(signal: number | string): boolean
2 participants