feat(async): add deadline to async module
#1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdalisue
force-pushed
the
async-timeout
branch
2 times, most recently
from
96bc133
to
1600203
Compare
wperron
requested changes
Jul 10, 2021
wperron
reviewed
Jul 10, 2021
|
I'll squash commits once reviews are completed. |
wperron
reviewed
Jul 12, 2021
async/README.md
Outdated
| import { deadline } from "https://deno.land/std/async/mod.ts"; | ||
|
|
||
| const delayedPromise = delay(1000); | ||
| // Above throws `DeadlineError` after 10 ms |
There was a problem hiding this comment.
Except it's not above anymore 😉
There was a problem hiding this comment.
Oops. I'll reword.
|
Also, just make sure you rebase, but you don't have to squash, we can do it on merge ourselves |
lambdalisue
force-pushed
the
async-timeout
branch
from
93566d6
to
63a4edf
Compare
|
Rebase & force pushed 👍 |
wperron
approved these changes
Jul 12, 2021
lambdalisue
changed the title
timeout to async moduledeadline to async module
lambdalisue
added a commit
to vim-denops/denops.vim
that referenced
this pull request
Jul 15, 2021
The `deadline` is added from [email protected] denoland/std#1022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm not sure if you like the idea but I added a
timeoutfunction to theasyncmodule while simple code withdelay(100).then(() => new Error("Timeout"))would cause the following errorAdded
timeoutfunction callclearTimeoutto avoid such kind of error.Please close this PR if it does not suit the std requirements.