Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JavaScript versions of std/hash #658

Closed
caspervonb opened this issue Jul 7, 2020 · 3 comments
Closed

Remove JavaScript versions of std/hash #658

caspervonb opened this issue Jul 7, 2020 · 3 comments

Comments

@caspervonb
Copy link
Contributor

Right now we're doubling up on a lot of hashing algorithms.

The WebAssembly implementation is a good first pass but if we're keeping single algorithm imports (e.g std/hash/sha1.ts) then we should probably generate WebAssembly backed classes for these as-well.

@kitsonk
Copy link
Contributor

kitsonk commented Jul 7, 2020

That would be a breaking change, but it feels like one we should take, before it gets too late.

As far as single algorithm imports, it isn't necessary, in my opinion to preserve. It was the nature of the way they were being built up versus intentional design. Having a single API is better.

It maybe worth looking at the single API as a whole though... In particular the hash/mod.ts doesn't have HMAC variants built in and that would be required to replace some of the stand alone ones.

An interim step could be to just gut the standalone ones. They have things like .array() which could easily be replicated with the WebAssembly ones.

@stale
Copy link

stale bot commented Jan 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@iuioiua
Copy link
Contributor

iuioiua commented Aug 17, 2022

@bartlomieju, is this able to be closed? std/hash is deprecated.

@kt3k kt3k closed this as completed Aug 19, 2022
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants