Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions in bytes should not be prefixed with "bytes" #447

Closed
ry opened this issue May 24, 2019 · 2 comments · Fixed by #448
Closed

functions in bytes should not be prefixed with "bytes" #447

ry opened this issue May 24, 2019 · 2 comments · Fixed by #448

Comments

@ry
Copy link
Member

ry commented May 24, 2019

EG bytesFindIndex() ... it should be findIndex()
https://github.com/denoland/deno_std/blob/bd46d60ded3197d93a52ede92eba7302df9b4713/bytes/bytes.ts#L5

@axetroy
Copy link
Contributor

axetroy commented May 24, 2019

I will do this.

By the way

Is this directory structure a bit strange? eg bytes/bytes.ts

import { repeat } from 'https://deno.land/x/bytes/bytes.ts';

Should it be reconstituted like this

import { repeat } from 'https://deno.land/x/bytes/mod.ts';

@ry
Copy link
Member Author

ry commented May 24, 2019

Should it be reconstituted like this

Sure. Also strings/strings.ts

@ry ry closed this as completed in #448 May 24, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this issue Oct 24, 2024
closes denoland#377.  

this disallows users from submitting duplicate entries.  
upon submission all user entries are checked for uniqueness on either
`title` or `url`.

---------

Co-authored-by: Asher Gomez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants