feat(http): Allow passing path and domain attributes while removing c…

…ookies (#1005)
denoland · Jul 6, 2021 · d8e61e4 · d8e61e4
1 parent 416ef01
commit d8e61e4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/http/cookie.ts b/http/cookie.ts
@@ -193,11 +193,18 @@ export function setCookie(res: { headers?: Headers }, cookie: Cookie): void {
  * Example:
  *
  *     deleteCookie(res,'foo');
+ *     deleteCookie(res,'foo', {path:'/demo'});
+ *     deleteCookie(res,'foo', {domain:'deno.land'});
  */
-export function deleteCookie(res: { headers?: Headers }, name: string): void {
+export function deleteCookie(
+  res: { headers?: Headers },
+  name: string,
+  attributes?: { path?: string; domain?: string },
+): void {
   setCookie(res, {
     name: name,
     value: "",
     expires: new Date(0),
+    ...attributes,
   });
 }
diff --git a/http/cookie_test.ts b/http/cookie_test.ts
@@ -135,6 +135,18 @@ Deno.test({
       res.headers?.get("Set-Cookie"),
       "deno=; Expires=Thu, 01 Jan 1970 00:00:00 GMT",
     );
+    res.headers = new Headers();
+    setCookie(res, {
+      name: "Space",
+      value: "Cat",
+      domain: "deno.land",
+      path: "/",
+    });
+    deleteCookie(res, "Space", { domain: "", path: "" });
+    assertEquals(
+      res.headers?.get("Set-Cookie"),
+      "Space=Cat; Domain=deno.land; Path=/, Space=; Expires=Thu, 01 Jan 1970 00:00:00 GMT",
+    );
   },
 });