feat: rust bindgen and publish flow #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
force-pushed
the
x/bindgen
branch
6 times, most recently
from
f6748f2 to
da1f96f
Compare
ry
reviewed
Jun 26, 2024
| for define in target['defines']: | ||
| args.append(f'-D{define}') | ||
|
|
||
| print('\0'.join(args), end="") |
There was a problem hiding this comment.
The null delimiter makes it not very human readable. What about \n?
There was a problem hiding this comment.
it turns out that using \n makes msvc very unhappy for some reason. \0 works so i think its ok to leave for now.
ry
reviewed
Jun 26, 2024
ry
reviewed
Jun 26, 2024
ry
reviewed
Jun 26, 2024
bartlomieju
reviewed
Jun 26, 2024
bartlomieju
reviewed
Jun 26, 2024
bartlomieju
reviewed
Jun 26, 2024
devsnek
force-pushed
the
x/bindgen
branch
2 times, most recently
from
f65963b to
58c2ba1
Compare
bartlomieju
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bindgen, which is a little bit complex due to build being inside
gn. I moved asizeofdefinition over just as a basic test but we should be able to migrate the entire struct definition and others in the future.