Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support URLs as strings #116

Merged
merged 1 commit into from
May 30, 2023
Merged

feat: support URLs as strings #116

merged 1 commit into from
May 30, 2023

Conversation

yacinehmito
Copy link
Contributor

Closes #62.

dsherret
dsherret approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit dfdd87d into denoland:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remote urls are not resolved correctly when passed in as string.
2 participants
@yacinehmito @dsherret