Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release url #121

Merged
merged 2 commits into from
May 3, 2023
Merged

fix: release url #121

merged 2 commits into from
May 3, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Apr 24, 2023

This PR tries to fix the url for fetching the dynamic lib when --release flag is passed to deno_bindgen cli

@kt3k kt3k requested a review from littledivy April 24, 2023 05:47
@kt3k kt3k mentioned this pull request Apr 24, 2023
Merged
littledivy
littledivy approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skanehira skanehira mentioned this pull request May 3, 2023
Open
@kt3k kt3k merged commit ed15bca into denoland:main May 3, 2023
@kt3k kt3k deleted the fix-load-url branch May 3, 2023 05:01
@kt3k kt3k mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @littledivy