fix(op_crates/fetch): redirect: "manual" fetch should return type: "default" response
#8353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nayeemrmn what's your opinion on this PR? |
nayeemrmn
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Similar to #6868, my preference is that spec-breaking behaviour can only invoked by passing an option with key Deno.<symbol>. But there's no such infrastructure yet. If that proposal gets approved we can always revisit this.
kitsonk
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intentionally breaks from spec (but aligns to other server side implementations of
fetchlike Cloudflare Workers).Closes #8351
Closes #4389