refactor(cli): migrate runtime compile/bundle to new infrastructure #8192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
glad to see cli/module_graph.rs go! can cli/tsc.rs be removed too? |
ry
reviewed
Oct 30, 2020
|
Oops. |
bartlomieju
reviewed
Oct 31, 2020
There was a problem hiding this comment.
Great work @kitsonk 🚀 I have only a handful of low-impact comments. Can't wait to land this one!
kitsonk
force-pushed
the
feat_runtime_compile_bundle
branch
from
c2e4f47 to
16a6dfb
Compare
jannes
pushed a commit
to jannes/deno
that referenced
this pull request
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8060
Couple notes:
99_compiler.js./foo.tsit will return withfile:///foo.ts.jsandfile:///foo.ts.js.map. This makes it a lot easier to deal with everything internally. Users can provide sources with any URI that was as well. It should also make it easier to feed externally gathered sources to the APIs.typeswas strange to begin with for the compiler APIs and I think we need revisit supporting that all together anyways.