add NO_PROXY to deno help and add the test code
#7048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ry
reviewed
Aug 14, 2020
| @@ -195,6 +195,8 @@ static ENV_VARIABLES_HELP: &str = "ENVIRONMENT VARIABLES: | |||
| HTTP_PROXY Proxy address for HTTP requests | |||
| (module downloads, fetch) | |||
| HTTPS_PROXY Proxy address for HTTPS requests | |||
| (module downloads, fetch) | |||
| NO_PROXY List of hosts which do not use proxy | |||
| (module downloads, fetch)"; | |||
There was a problem hiding this comment.
Is it comma separated list? Maybe mention that here?
There was a problem hiding this comment.
Is it comma separated list?
Yes. I fixed the description.
ry
approved these changes
Aug 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqwestsupportedNO_PROXYenvironment variable(seanmonstar/reqwest#877).I fixed
deno helpand added the test code.