feat(cli) add dev, ino and nlink fields to Deno.FileInfo on Windows #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Jul 2, 2020
bartlomieju
added
cli
|
|
|
Was checking in on this, no changes or activity (rust-lang/rust#63010) |
|
@caspervonb if there are no signs of stabilization of required API can we close this PR for now? |
|
Sigh, was hoping there would be some movement on this by now. Closing without merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fills in the dev, ino and nlink fields on Windows when called from Deno.fstat, Deno.lstat or Deno.stat.
These fields come from GetFileInformationByHandle which have been rolled into the std::os::windows::fs::MetadataExt trait as a nightly gated feature so this is blocking on the "windows_by_handle" feature being rolled out to a stable release.
In other words; do not merge, leaving this here as a draft proof of concept for now.