Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorg: cli/js/compiler/, move more API to cli/js/web/ #4310

Merged
merged 13 commits into from
Mar 11, 2020
Merged

reorg: cli/js/compiler/, move more API to cli/js/web/ #4310

merged 13 commits into from
Mar 11, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Mar 10, 2020 •
edited
Loading

This PR:

  • moves compiler implementation to "cli/js/compiler/" directory
  • moves more APIs to "cli/js/web":
    • "console.ts"
    • "console_table.ts"
    • "performance.ts"
    • "timers.ts"
    • "workers.ts"
  • removes some dead code from "cli/js/"

Ref #4248

@bartlomieju bartlomieju changed the title [WIP] further cleanup to cli/js/ reorg: further cleanup to cli/js/ Mar 10, 2020
@bartlomieju bartlomieju requested a review from ry March 10, 2020 13:45
ry
ry approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/js/dispatch.ts Outdated
default:
return json.asyncMsgFromRust;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@bartlomieju
Copy link
Member Author

bartlomieju commented Mar 10, 2020 •
edited
Loading

Segfault strikes again:

$ ../../target/debug/deno run --reload --allow-net 053_import_compression/main.ts
Compile file:///Users/biwanczuk/dev/deno/cli/tests/053_import_compression/main.ts
Download http://127.0.0.1:4545/cli/tests/053_import_compression/gziped
Download http://127.0.0.1:4545/cli/tests/053_import_compression/brotli
gzip
brotli
[1]    34238 segmentation fault  ../../target/debug/deno run --reload --allow-net

EDIT: This segfault happens when reading HTTP body. When I added console log in cli/js/web/fetch.ts:225 I can't hit it again

EDIT2: Segfault is occasional...

@bartlomieju bartlomieju changed the title reorg: further cleanup to cli/js/ reorg: cli/js/compiler/, move more API to cli/js/web/ Mar 11, 2020
@bartlomieju bartlomieju merged commit 99a0c6d into denoland:master Mar 11, 2020
@bartlomieju bartlomieju deleted the cli_js_cleanup branch March 11, 2020 09:53
dubiousjim added a commit to dubiousjim/deno that referenced this pull request Mar 13, 2020
@dubiousjim
Merge remote-tracking branch 'denoland/master' into filesystem8g
af428e8 
* denoland/master:
  Remove doc strings from cli/js TS files (denoland#4329)
  upgrade: Rust 1.42.0 (denoland#4331)
  Enable std tests in debug mode (denoland#4332)
  fix: Node polyfill fsAppend rework (denoland#4322)
  v0.36.0
  Add waker to StreamResource to fix hang on close bugs (denoland#4293)
  reorg: Deno global initialization (denoland#4317)
  move compiler API tests to integration tests (denoland#4319)
  support permission mode in mkdir (denoland#4286)
  Stricter permissions for Deno.makeTemp* (denoland#4318)
  reorg: remove dispatch.ts, move signals, factor out web utils (denoland#4316)
  reorg: cli/js/compiler/, move more API to cli/js/web/ (denoland#4310)
  Improve dprint config (denoland#4314)
  doc(cli/flags): Reduce empty lines in help messages (denoland#4312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @ry