Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx: better error message for 'Cannot resolve module' #3402

Merged

Conversation

bartlomieju
Copy link
Member

Closes #2887

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,4 +1,4 @@
[WILDCARD]error: Uncaught NotFound: Cannot resolve module "[WILDCARD]/non-existent"
[WILDCARD]error: Uncaught NotFound: Cannot resolve module "[WILDCARD]/non-existent" from "[WILDCARD]/error_006_import_ext_failure.ts"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ry ry merged commit 658ec2a into denoland:master Nov 25, 2019
@bartlomieju bartlomieju deleted the refactor-better_error_message_on_not_found branch November 25, 2019 14:36
@kevinkassimo
Copy link
Contributor

@bartlomieju Seems we also probably need to account for ImportPrefixMissing case (also does not get a containing file reference in error message)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stack trace for 'Cannot resolve module'
3 participants