fix(check/lsp): correctly resolve compilerOptions.types #27686
Merged
+218
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
force-pushed
the
compiler-options-types
branch
from
bf2c75a to
a5d228e
Compare
nayeemrmn
reviewed
Jan 15, 2025
nayeemrmn
reviewed
Jan 15, 2025
nathanwhit
force-pushed
the
compiler-options-types
branch
from
9e35157 to
b98db29
Compare
dsherret
reviewed
Jan 15, 2025
dsherret
reviewed
Jan 15, 2025
dsherret
reviewed
Jan 15, 2025
dsherret
reviewed
Jan 15, 2025
nayeemrmn
approved these changes
Jan 16, 2025
bartlomieju
pushed a commit
that referenced
this pull request
Jan 16, 2025
Fixes #27062 In the LSP we were passing `npm` specifiers to TSC as roots, but TSC needs fully resolved specifiers (like the actual file path). In `deno check` we were often excluding the specifiers entirely from the roots. In both cases, we need to resolve the specifiers fully and then pass them to tsc
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27062
In the LSP we were passing
npmspecifiers to TSC as roots, but TSC needs fully resolved specifiers (like the actual file path).In
deno checkwe were often excluding the specifiers entirely from the roots.In both cases, we need to resolve the specifiers fully and then pass them to tsc