Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/console): ignore casing for named colors in css parsing #26466

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix(ext/console): ignore casing for named colors in css parsing #26466

merged 2 commits into from
Oct 22, 2024

Conversation

crowlKats
Copy link
Member

Fixes #26459

@crowlKats crowlKats changed the title fix(ext/console): ignore casing for color css parsing fix(ext/console): ignore casing for named colors in css parsing Oct 22, 2024
bartlomieju
bartlomieju approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, discussed offline, gonna land without a test because we currently have no way of testing in CI to force colors.

@crowlKats
Copy link
Member Author

@bartlomieju there is a test :)

@lucacasonato lucacasonato merged commit 9696e0b into denoland:main Oct 22, 2024
17 checks passed
@crowlKats crowlKats deleted the css-lowercase branch October 22, 2024 09:16
bartlomieju pushed a commit that referenced this pull request Oct 25, 2024
@crowlKats @bartlomieju
fix(ext/console): ignore casing for named colors in css parsing (#26466)
ad563c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS color and background-color are case-sensitive in console.log
3 participants
@crowlKats @lucacasonato @bartlomieju