Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ext/node): use concrete error types #26419

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Oct 19, 2024

except node crypto, keeping that as a followup PR as else this PR will get too complex

Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	runtime/errors.rs
@crowlKats crowlKats merged commit c71e020 into denoland:main Oct 24, 2024
17 checks passed
@crowlKats crowlKats deleted the node-error-rework branch October 24, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants