Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): interactive inlay hints #26382

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat(lsp): interactive inlay hints #26382

merged 1 commit into from
Oct 21, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Closes #26326. Implements ctrl+clickable inlay type hints.

@nayeemrmn nayeemrmn changed the title feat(lsp): parse inlay hint display parts from tsc feat(lsp): interactive inlay hints Oct 18, 2024
lucacasonato
lucacasonato approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 9fe2bf4 into denoland:main Oct 21, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-inlay-hint-display-part branch October 21, 2024 16:17
bartlomieju pushed a commit that referenced this pull request Oct 25, 2024
@nayeemrmn @bartlomieju
feat(lsp): interactive inlay hints (#26382)
7703f4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@dsherret dsherret Awaiting requested review from dsherret

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp: interactive inlay hints
2 participants
@nayeemrmn @lucacasonato