chore: Deprecate eval itests #25382
Merged
chore: Deprecate eval itests #25382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HasanAlrimawi
changed the title
Signed-off-by: David Sherret <[email protected]>
dsherret
reviewed
Sep 3, 2024
Signed-off-by: David Sherret <[email protected]>
dsherret
reviewed
Sep 3, 2024
| itest!(eval_basic { | ||
| args: "eval console.log(\"hello\")", | ||
| output_str: Some("hello\n"), | ||
| }); |
There was a problem hiding this comment.
I think ./tools/lint.js needs to be updated to have the new number though. Probably linting will fail on the ci
…awi/deno into deprecate-eval-itests
|
The test specs::eval::env_file keeps failing on the CI checks but it always succeeds on local runs. |
dsherret
reviewed
Sep 3, 2024
Signed-off-by: David Sherret <[email protected]>
Signed-off-by: Marvin Hagemeister <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves as a part of #22907 .