Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): panic on url_to_uri() #25238

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

nayeemrmn
Copy link
Collaborator

Fixes panic at:

Uri::from_str(url.as_str()).unwrap()
Reported by @marvinhagemeister. We don't know how it's reproduced but there is error handling now.

Also get rid of LspClientUrl, it's been made redundant by lsp_types::Uri. Clean up usage of uri / url / specifier in variable and method names.

@bartlomieju bartlomieju modified the milestones: 2.0.0, 2.0.0-rc.0 Aug 28, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 97d1635 into denoland:main Aug 28, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-url-to-uri branch August 29, 2024 00:04
lucacasonato pushed a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants