Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fetch): accept async iterables for body #24623

Merged
merged 20 commits into from
Aug 6, 2024
Merged

feat(fetch): accept async iterables for body #24623

merged 20 commits into from
Aug 6, 2024

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Jul 17, 2024 •
edited
Loading

Implements whatwg/webidl#1397
Fixes #21454
Closes #24849

@crowlKats crowlKats marked this pull request as ready for review July 17, 2024 15:20
lucacasonato
lucacasonato reviewed Aug 2, 2024
View reviewed changes
ext/webidl/00_webidl.js Outdated Show resolved Hide resolved
ext/fetch/22_body.js Outdated Show resolved Hide resolved
ext/webidl/00_webidl.js Outdated Show resolved Hide resolved
ext/webidl/00_webidl.js Outdated Show resolved Hide resolved
ext/webidl/00_webidl.js Outdated Show resolved Hide resolved
ext/webidl/00_webidl.js Outdated Show resolved Hide resolved
ext/webidl/00_webidl.js Outdated Show resolved Hide resolved
ext/webidl/00_webidl.js Outdated Show resolved Hide resolved
ext/webidl/00_webidl.js Outdated Show resolved Hide resolved
@crowlKats crowlKats requested a review from lucacasonato August 2, 2024 23:41
@crowlKats crowlKats changed the title feat(webidl): add async iterable converter feat(fetch): accept async iterables for body Aug 6, 2024
lucacasonato
lucacasonato approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit ba40347 into denoland:main Aug 6, 2024
17 checks passed
@crowlKats crowlKats deleted the webidl-async-iterable branch August 6, 2024 07:13
@iuioiua iuioiua mentioned this pull request Aug 6, 2024
Merged
@petamoriken petamoriken mentioned this pull request Aug 20, 2024
Merged
lucacasonato added a commit that referenced this pull request Aug 26, 2024
@lucacasonato
Revert "feat(fetch): accept async iterables for body (#24623)"
8693f02 
This reverts commit ba40347.
@lucacasonato lucacasonato mentioned this pull request Aug 26, 2024
Merged
lucacasonato added a commit that referenced this pull request Aug 26, 2024
@lucacasonato
Revert "feat(fetch): accept async iterables for body" (#25207)
e53678f 
Unfortunately this caused a regression:
#25203.

Need to do some more upstream spec work to fix this before this can be
re-landed.

Reverts #24623
lucacasonato added a commit that referenced this pull request Aug 29, 2024
@lucacasonato
Revert "feat(fetch): accept async iterables for body" (#25207)
824ee13 
Unfortunately this caused a regression:
#25203.

Need to do some more upstream spec work to fix this before this can be
re-landed.

Reverts #24623
@lucacasonato lucacasonato mentioned this pull request Nov 15, 2024
Merged
lucacasonato added a commit that referenced this pull request Nov 15, 2024
@lucacasonato @crowlKats
feat(fetch): accept async iterables for body (#26882)
b8cf259 
Reland of #24623, but with a fix for `String` objects.

Co-authored-by: crowlkats <[email protected]>
bartlomieju pushed a commit that referenced this pull request Nov 26, 2024
@petamoriken
fix(streams): reject string in ReadableStream.from type (#25116)
4330ef5 
WebIDL `async iterable<T>` type rejects `string`

Ref whatwg/webidl#1397, #24623
bartlomieju pushed a commit that referenced this pull request Nov 28, 2024
@petamoriken @bartlomieju
fix(streams): reject string in ReadableStream.from type (#25116)
2ee6b1a 
WebIDL `async iterable<T>` type rejects `string`

Ref whatwg/webidl#1397, #24623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@crowlKats @lucacasonato