refactor(ext/tls): use cppgc to deduplicate the tls key loading code #23289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Apr 17, 2024
| @@ -131,6 +137,36 @@ class TlsListener extends Listener { | |||
| } | |||
| } | |||
|
|
|||
| function hasTlsKeyPairOptions(options) { | |||
| return (ReflectHas(options, "cert") || ReflectHas(options, "key") || | |||
There was a problem hiding this comment.
This change made a regression. Previously, if cert and key in options had undefined value, the server was not failing but now it does fail.
Context: nitrojs/nitro#2373 -- tools might get these options from sources like environment variables. now need to explicitly call delete on prop.
littledivy
pushed a commit
to littledivy/deno
that referenced
this pull request
Apr 19, 2024
…enoland#23289) Pass the certificates and key files as CPPGC objects. Towards denoland#23233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the certificates and key files as CPPGC objects.
Towards #23233