Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate Deno.write() and Deno.writeSync() #22064

Merged
merged 4 commits into from
Jan 24, 2024
Merged

feat: deprecate Deno.write() and Deno.writeSync() #22064

merged 4 commits into from
Jan 24, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jan 24, 2024

For removal in Deno v2.

@iuioiua iuioiua changed the title feat: re-deprecate Deno.write() and Deno.writeSync() feat: deprecate Deno.write() and Deno.writeSync() Jan 24, 2024
@iuioiua
Copy link
Contributor Author

iuioiua commented Jan 24, 2024

Will fix shortly

@bartlomieju bartlomieju added this to the 1.40 milestone Jan 24, 2024
littledivy
littledivy approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju added the ci-bench put this on a PR to run the benchmarks label Jan 24, 2024
@bartlomieju bartlomieju merged commit a5a973e into denoland:main Jan 24, 2024
14 checks passed
@iuioiua iuioiua deleted the re-deprecate-Deno.write branch January 24, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
ci-bench put this on a PR to run the benchmarks
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.
3 participants
@iuioiua @littledivy @bartlomieju