fix(BREAKING): remove dead --prompt flag
#22038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
@iuioiua we probably shoudln't be categorizing most of these PRs as |
iuioiua
changed the title
--prompt flag--prompt flag
|
Ah, ok. FYI, I talked to Bartek offline, and we both think this might be fine to have as part of the 1.40. This would only be breaking if someone hadn't updated since nearly 2 years ago when the behaviour was changed. What do we think? |
|
Sure. Easy for them to fix |
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Jan 23, 2024
It appears the `--prompt` flag has done nothing for some time. Perhaps, since denoland#13650. Classifying this as a dead functionality removal for this reason. Did this while working on denoland#22021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the
--promptflag has done nothing for some time. Perhaps, since #13650. Classifying this as a dead functionality removal for this reason.Did this while working on #22021.